Read on Twitter
Been reading about code reviews best practices and I keep coming across the advice to "ask questions instead of giving statements". I disagree with this. Asking questions to which the other person doesn't know the answer is condescending and can create feelings of inadequacy.
"Why did you do X?"
"Because I don't know any better?"
It's much better (IMO) to say: "I noticed you did X. I think Y is better because..." (and give a good explanation, it's better if you can throw in some links so the person can read up on it).
"Because I don't know any better?"
It's much better (IMO) to say: "I noticed you did X. I think Y is better because..." (and give a good explanation, it's better if you can throw in some links so the person can read up on it).
Also, don't forget to give praise! Coming to a code review with 20 requested changes and not a single "Good work!" or "I like that what you did here!" can be very demoralizing.
And if something is only your personal preference or opinion and you insist on picking on it, make sure to give plenty of justification why you're bringing it up and be prepared to approve the code even if the code owner disagrees and doesn't want to apply your change.
And last but not least, avoid words like "just" and "simply" like the coronavirus. It makes the other person feel stupid and inadequate and it just sucks. I know most people do it as a habit, but it's a really bad habit that you should try to break.
